FLUME-3093: Groundwork for version changes in root pom #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted hard-coded version numbers to root pom.xml No version number changed in this step. The old used versions are named with -old suffix. guava-old.version httpclient-old.version mvn-surefire-plugin-old.version mvn-surefire-plugin-old-morphline.version
|
Tested with mvn dependency:tree : no difference detected. |
mcsanady
commented
Jun 26, 2017
|
I accidentally deleted the branch |
szaboferee
reviewed
Jun 29, 2017
flume-ng-auth/pom.xml
Outdated
| @@ -37,7 +37,7 @@ limitations under the License. | |||
| <plugin> | |||
| <groupId>org.apache.felix</groupId> | |||
| <artifactId>maven-bundle-plugin</artifactId> | |||
| <version>2.3.7</version> | |||
| <version>${bundle-plugin.version}</version> | |||
There was a problem hiding this comment.
why don't we use <pluginManagement> in the parent pom?
| @@ -86,14 +86,14 @@ | |||
| <dependency> | |||
| <groupId>org.mockito</groupId> | |||
| <artifactId>mockito-all</artifactId> | |||
| <version>1.9.0</version> | |||
| <version>${mockito.version}</version> | |||
There was a problem hiding this comment.
Why don't we use <dependencyManagement> in the parent pom
flume-ng-node/pom.xml
Outdated
| @@ -147,7 +147,7 @@ | |||
| <dependency> | |||
| <groupId>com.github.stefanbirkner</groupId> | |||
| <artifactId>system-rules</artifactId> | |||
| <version>1.16.0</version> | |||
| <version>${system-rules.version}</version> | |||
| <wiremock.version>1.53</wiremock.version> | ||
| <guava.version>18.0</guava.version> | ||
| </properties> | ||
|
|
There was a problem hiding this comment.
Now, that we use common versions, we might would like to look at the exlusions in the dependencies. Again, the version numbers could come from dependencyManagement
|
Hi @mcsanady, |
mcsanady
pushed a commit
to mcsanady/flume
that referenced
this pull request
Mar 13, 2018
This commit extracts the version numbers from the subprojects' pom.xml to the root pom.xml without introducing any other change (i.e. the dependency tree didn't change) This closes apache#132 Reviewers: Ferenc Szabo, Attila Simon (Miklos Csanady via Denes Arvay) Change-Id: Ib3aaf685c2b6bc72242415d9204d1c282d4be372
waidr
pushed a commit
to waidr/flume
that referenced
this pull request
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted hard-coded version numbers to root pom.xml
No version number changed in this step. The old used versions are named with -old suffix.
guava-old.version
httpclient-old.version
mvn-surefire-plugin-old.version
mvn-surefire-plugin-old-morphline.version