HttpSink. Fix bad response handling. #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a bad response, connection.getInputStream () returns null. I'm adding a check for this. If the answer is bad - try to close ErrorStream.
HttpSink. Fix bad response handling.
|
@filippovmn : thank you for the pull request! Is there an easy way to reproduce the faulty behavior in order to validate the patch? |
|
@bessbd |
added 3 commits
July 4, 2017 17:27
Checks the possibility of selectively skipping erroneous events
|
@bessbd |
Validation of the use of сonfiguration for critical responses
|
I've run the tests and it looks fine to me. |
|
LGTM, +1 |
|
@filippovmn : thank you for the patch! |
szaboferee
pushed a commit
to szaboferee/flume
that referenced
this pull request
Jul 31, 2017
After a bad response, connection.getInputStream() returns null. This patch adds a check for this. This closes apache#139 Reviewers: Bessenyei Balázs Donát (filippovmn via Bessenyei Balázs Donát)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a bad response, connection.getInputStream () returns null. I'm adding a check for this. If the answer is bad - try to close ErrorStream.