FLUME-3282 Use slf4j in every component #233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed http sink to log with slf4j instead of log4j. Changed some test to use slf4j as well.
szaboferee
force-pushed
the
FLUME-3282
branch
from
31c7d3e
to
f2b5d1e
Compare
|
LGTM. +1 |
|
Thanks for the contribution. Now the logging looks much cleaner. Wouldn't it be possible to move all log4j exclusions to the dependency management section? In this case it would be handled in one common place, not in the submodules. |
turcsanyip
approved these changes
Nov 19, 2018
szaboferee
added a commit
to szaboferee/flume
that referenced
this pull request
Jan 16, 2019
Changed http sink to log with slf4j instead of log4j. Changed some test to use slf4j as well. This closes apache#233 Reviewers: Peter Turcsanyi, Endre Major (Ferenc Szabo via Ferenc Szabo) Change-Id: I04f28a496164683fb10810e98e22956468ce86bd
waidr
pushed a commit
to waidr/flume
that referenced
this pull request
Jul 24, 2019
double write for pili-alifetcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed http sink to log with slf4j instead of log4j.
Changed some test to use slf4j as well.