FLUME-3101 Add maxBatchCount config property to Taildir Source. #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are multiple files in the path(s) that need to be tailed and there is a file written by high frequency, then Taildir can read the batchSize size events from that file every time. This can lead to an endless loop and Taildir will only read data from the busy file, while other files will not be processed. Another problem is that in this case TaildirSource will be unresponsive to stop requests too. This commit handles this situation by introducing a new config property called maxBatchCount. It controls the number of batches being read consecutively from the same file. After reading maxBatchCount rounds from a file, Taildir will switch to another file / will have a break in the processing. This change is based on hunshenshi's patch.
Inconsistent locking of the new maxBatchCount instance variable.The same problem affects other variables in the class too. It will be handled later.
szaboferee
reviewed
Nov 22, 2018
There was a problem hiding this comment.
Thank you for the contribution @turcsanyip
It looks good to me, only some minor changes needed.
| @@ -1401,6 +1402,7 @@ Example for agent named a1: | |||
| a1.sources.r1.headers.f2.headerKey1 = value2 | |||
| a1.sources.r1.headers.f2.headerKey2 = value2-2 | |||
| a1.sources.r1.fileHeader = true | |||
| a1.sources.ri.numThreshold = 1000 | |||
There was a problem hiding this comment.
the example is different than the parameter name
There was a problem hiding this comment.
Thanks for catching it. Fixed.
| @@ -1375,6 +1375,7 @@ skipToEnd false Whether to sk | |||
| idleTimeout 120000 Time (ms) to close inactive files. If the closed file is appended new lines to, this source will automatically re-open it. | |||
| writePosInterval 3000 Interval time (ms) to write the last position of each file on the position file. | |||
| batchSize 100 Max number of lines to read and send to the channel at a time. Using the default is usually fine. | |||
| maxBatchCount Long.MAX_VALUE Controls the number of batches being read consecutively from the same file. It can be used to prevent reading a file in endless loop when the file is written by high frequency. | |||
There was a problem hiding this comment.
I would add a little bit more explanation. for example:
If the source is tailing multiple files and one of them is written at a fast rate, it can prevent other files to be read. In this case lower this value.
- fix parameter name in the example - refine parameter description
szaboferee
pushed a commit
to szaboferee/flume
that referenced
this pull request
Jan 16, 2019
If there are multiple files in the path(s) that need to be tailed and there is a file written by high frequency, then Taildir can read the batchSize size events from that file every time. This can lead to an endless loop and Taildir will only read data from the busy file, while other files will not be processed. Another problem is that in this case TaildirSource will be unresponsive to stop requests too. This commit handles this situation by introducing a new config property called maxBatchCount. It controls the number of batches being read consecutively from the same file. After reading maxBatchCount rounds from a file, Taildir will switch to another file / will have a break in the processing. This change is based on hunshenshi's patch. This closes apache#240 Reviewers: Ferenc Szabo, Endre Major (Peter Turcsanyi via Ferenc Szabo)
waidr
pushed a commit
to waidr/flume
that referenced
this pull request
Jul 24, 2019
sparkcontext stop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are multiple files in the path(s) that need to be tailed and there
is a file written by high frequency, then Taildir can read the batchSize size
events from that file every time. This can lead to an endless loop and Taildir
will only read data from the busy file, while other files will not be
processed.
Another problem is that in this case TaildirSource will be unresponsive to
stop requests too.
This commit handles this situation by introducing a new config property called
maxBatchCount. It controls the number of batches being read consecutively
from the same file. After reading maxBatchCount rounds from a file, Taildir
will switch to another file / will have a break in the processing.
This change is based on hunshenshi's patch.