Replace ant build with cmake #14
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| cmake_minimum_required(VERSION 3.13) | ||
| include(src/cmake/projectVersionDetails.cmake) | ||
| project(log4cxx VERSION ${log4cxx_VER} LANGUAGES CXX) | ||
| include(CTest) | ||
|
|
||
| # FindAPR and FindAPR-util are not provided by APR and APR-Util so source them locally | ||
| list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}/src/cmake") | ||
|
|
||
| # Find Apache Runtime | ||
| find_package(APR QUIET) | ||
| # If APR find module sets the cache, the following will do nothing | ||
| find_path(APR_INCLUDE_DIR apr.h PATH_SUFFIXES apr-1) | ||
| find_library(APR_LIBRARIES NAMES libapr-1 apr-1) | ||
|
|
||
| # Find Apache Runtime Utilities | ||
| find_package(APR-Util QUIET) | ||
| # If APR-UTIL find module sets the cache, the following will do nothing | ||
| find_path(APR_UTIL_INCLUDE_DIR apu.h PATH_SUFFIXES apr-1) | ||
| find_library(APR_UTIL_LIBRARIES NAMES libaprutil-1 aprutil-1) | ||
|
There was a problem hiding this comment. Shouldn't this use FindPkgConfig and pkg_check_modules on Unix systems instead of find_package? There was a problem hiding this comment. DO APR and APR-UTIL provide support pkg-config? There was a problem hiding this comment. As far as I'm aware they do; I just tried this on Debian 10(buster), and it works properly though. I'm not sure what is best. Maybe this is better as a fallback if pkg_check_modules fails? There was a problem hiding this comment. The best practices from Professional CMake book include the statement: I am inclined to stick with find_package if that is OK. |
||
|
|
||
| # Building | ||
| add_subdirectory(src) | ||
|
|
||
| ## Installing | ||
| install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/src/main/include/log4cxx | ||
| DESTINATION ${CMAKE_INSTALL_INCLUDEDIR} | ||
| FILES_MATCHING PATTERN "*.h" | ||
| ) | ||
| install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/src/main/include/log4cxx | ||
| DESTINATION ${CMAKE_INSTALL_INCLUDEDIR} | ||
| FILES_MATCHING PATTERN "*.h" | ||
| ) | ||
|
|
||
| install(TARGETS log4cxx EXPORT log4cxxTargets | ||
| RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR} | ||
| ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR} | ||
| LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} | ||
| INCLUDES DESTINATION ${CMAKE_INSTALL_INCLUDEDIR} | ||
| ) | ||
stephen-webb marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| IF(WIN32 AND LOG4CXX_INSTALL_PDB) | ||
| INSTALL(FILES $<TARGET_PDB_FILE:log4cxx> | ||
| DESTINATION ${CMAKE_INSTALL_BINDIR} | ||
| CONFIGURATIONS RelWithDebInfo Debug | ||
| ) | ||
| ENDIF() | ||
|
|
||
| # create export file which can be imported by other cmake projects | ||
| install(EXPORT log4cxxTargets | ||
| FILE log4cxx-targets.cmake | ||
| NAMESPACE log4cxx:: | ||
| DESTINATION share/cmake/log4cxx | ||
| ) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to have a lower version of cmake? What I generally do is to target the version of CMake that is in the oldstable version of Debian(as of right now, Debian 9(stretch) has cmake 3.7). This is not a requirement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I may have used some cmake that requires 3.13. It was 6 months ago so I cannot recall exact details.
I have been trying to follow best practices in Professional CMake (4th Edition)