Add support for building log4cxx as a statically linked library on Windows

[stephen-webb]

Replacement for PR #20

[ams-tschoening]

Any reason why -DAPU_STATIC and -DAPR_STATIC are not documented with something like =off|on , like -DBUILD_SHARED_LIBS is? Does this work differently or ...?

[stephen-webb]

No, they work the same, except the Build shared is on by default. The =on does no more than the existence of a definition.

…

On Mon, Mar 30, 2020, 6:44 PM Thorsten Schöning ***@***.***> wrote: ***@***.**** requested changes on this pull request. ------------------------------ In src/site/apt/building/cmake.apt <#21 (comment)>: > @@ -50,6 +50,12 @@ $ sudo make install *------------------------+---------------------------------------------------------------------------------------------+ | -DBUILD_SHARED_LIBS=off| Build log4cxx as a static library. A dynamically linked log4cxx library is built by default.| | | Any compilation unit that includes a log4cxx header must define LOG4CXX_STATIC. | +*------------------------+---------------------------------------------------------------------------------------------+ +| -DAPU_STATIC | Link to the APR-Util static library. By default, the log4cxx shared library is linked to the| Any reason why -DAPU_STATIC and -DAPR_STATIC are not documented with something like =off|on , like -DBUILD_SHARED_LIBS is? Does this work differently or ...? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#21 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANLOSDWPWKXFOJOFOJQBYKTRKBEUPANCNFSM4LEUWTVQ> .

[stephen-webb]

Correction, =yes is equivalent to existence of a definition

…

On Mon, Mar 30, 2020, 7:10 PM Stephen Webb ***@***.***> wrote: No, they work the same, except the Build shared is on by default. The =on does no more than the existence of a definition. On Mon, Mar 30, 2020, 6:44 PM Thorsten Schöning ***@***.***> wrote: > ***@***.**** requested changes on this pull request. > ------------------------------ > > In src/site/apt/building/cmake.apt > <#21 (comment)> > : > > > @@ -50,6 +50,12 @@ $ sudo make install > *------------------------+---------------------------------------------------------------------------------------------+ > | -DBUILD_SHARED_LIBS=off| Build log4cxx as a static library. A dynamically linked log4cxx library is built by default.| > | | Any compilation unit that includes a log4cxx header must define LOG4CXX_STATIC. | > +*------------------------+---------------------------------------------------------------------------------------------+ > +| -DAPU_STATIC | Link to the APR-Util static library. By default, the log4cxx shared library is linked to the| > > Any reason why -DAPU_STATIC and -DAPR_STATIC are not documented with > something like =off|on , like -DBUILD_SHARED_LIBS is? Does this work > differently or ...? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#21 (review)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ANLOSDWPWKXFOJOFOJQBYKTRKBEUPANCNFSM4LEUWTVQ> > . >

[ams-tschoening]

Then please add =yes|no|on|off as necessary/useful for -D*_STATIC, so that its in line with the other documented options. Afterwards I'm going to merge.