Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using C++20, optionally add in comma for varargs #345

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

rm5248
Copy link
Contributor

@rm5248 rm5248 commented Feb 4, 2024

See: #344

The FMT macros now work with only one argument when using C++20 or greater.

@swebb2066
Copy link
Contributor

You can now also undo the changes in throughput

@rm5248
Copy link
Contributor Author

rm5248 commented Feb 5, 2024

Unfortunately since this is a C++20 only fix, that build would fail with earlier versions.

The optional GCC fix as well (##__VA_ARGS__) only works if GNU extensions are enabled. So it works if you compile with -std=gnu++11 but fails with -std=c++11. There doesn't seem to be a way to test if this is enabled or not at compile time.

@rm5248 rm5248 merged commit 50fe1df into master Feb 5, 2024
24 checks passed
@rm5248 rm5248 deleted the fix-fmt-macros branch February 5, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants