Skip to content

Commit

Permalink
Revert changes to java8-incompat-fixes profile
Browse files Browse the repository at this point in the history
  • Loading branch information
ppkarwasz committed Apr 26, 2024
1 parent 12757b8 commit 139ce2d
Show file tree
Hide file tree
Showing 5 changed files with 115 additions and 4 deletions.
4 changes: 0 additions & 4 deletions .mvn/jvm.config
Expand Up @@ -8,8 +8,4 @@
--add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED
--add-opens jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED
--add-opens jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED
--add-opens java.base/java.io=ALL-UNNAMED
--add-opens java.base/java.lang=ALL-UNNAMED
--add-opens java.base/java.net=ALL-UNNAMED
--add-opens java.base/java.util=ALL-UNNAMED
-Dfile.encoding=UTF-8
33 changes: 33 additions & 0 deletions log4j-1.2-api/pom.xml
Expand Up @@ -142,4 +142,37 @@
<scope>test</scope>
</dependency>
</dependencies>

<profiles>

<!-- Fixes incompatible with Java 8 -->
<profile>

<id>java8-incompat-fixes</id>

<!-- If this variable is present the `java8-tests` profile is active -->
<activation>
<property>
<name>!env.JAVA_HOME_8_X64</name>
</property>
</activation>

<!-- Illegal access is disabled by default in Java 16 due to JEP-396.
We are relaxing it for tests. -->
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<argLine>--add-opens java.base/java.io=ALL-UNNAMED</argLine>
</configuration>
</plugin>
</plugins>
</build>

</profile>

</profiles>

</project>
16 changes: 16 additions & 0 deletions log4j-core-test/pom.xml
Expand Up @@ -402,6 +402,22 @@
</dependency>
</dependencies>

<!-- Illegal access is disabled by default in Java 16 due to JEP-396.
We are relaxing it for tests. -->
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<argLine>--add-opens java.base/java.lang=ALL-UNNAMED
--add-opens java.base/java.net=ALL-UNNAMED
--add-opens java.base/java.util=ALL-UNNAMED</argLine>
</configuration>
</plugin>
</plugins>
</build>

</profile>

<!--
Expand Down
33 changes: 33 additions & 0 deletions log4j-jpa/pom.xml
Expand Up @@ -96,4 +96,37 @@
<scope>test</scope>
</dependency>
</dependencies>

<profiles>

<!-- Fixes incompatible with Java 8 -->
<profile>

<id>java8-incompat-fixes</id>

<!-- If this variable is present the `java8-tests` profile is active -->
<activation>
<property>
<name>!env.JAVA_HOME_8_X64</name>
</property>
</activation>

<!-- Illegal access is disabled by default in Java 16 due to JEP-396.
We are relaxing it for tests. -->
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<argLine>--add-opens java.base/java.lang=ALL-UNNAMED</argLine>
</configuration>
</plugin>
</plugins>
</build>

</profile>

</profiles>

</project>
33 changes: 33 additions & 0 deletions log4j-osgi-test/pom.xml
Expand Up @@ -225,4 +225,37 @@

</plugins>
</build>

<profiles>

<!-- Fixes incompatible with Java 8 -->
<profile>

<id>java8-incompat-fixes</id>

<!-- If this variable is present the `java8-tests` profile is active -->
<activation>
<property>
<name>!env.JAVA_HOME_8_X64</name>
</property>
</activation>

<!-- Illegal access is disabled by default in Java 16 due to JEP-396.
We are relaxing it for tests. -->
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<argLine>--add-opens java.base/java.net=ALL-UNNAMED</argLine>
</configuration>
</plugin>
</plugins>
</build>

</profile>

</profiles>

</project>

0 comments on commit 139ce2d

Please sign in to comment.