Skip to content

Commit

Permalink
Remove redundant parameter passing in MessageResolver (#2183)
Browse files Browse the repository at this point in the history
  • Loading branch information
RocMarshal authored and vy committed Jan 11, 2024
1 parent dc4bedf commit 40d18b1
Showing 1 changed file with 3 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -99,17 +99,16 @@ private static EventResolver createInternalResolver(final TemplateResolverConfig
if (stringified && fallbackKey != null) {
throw new IllegalArgumentException("fallbackKey is not allowed when stringified is enable: " + config);
}
return stringified ? createStringResolver(fallbackKey) : createObjectResolver(fallbackKey);
return stringified ? createStringResolver() : createObjectResolver(fallbackKey);
}

@Override
public void resolve(final LogEvent logEvent, final JsonWriter jsonWriter) {
internalResolver.resolve(logEvent, jsonWriter);
}

private static EventResolver createStringResolver(final String fallbackKey) {
return (final LogEvent logEvent, final JsonWriter jsonWriter) ->
resolveString(fallbackKey, logEvent, jsonWriter);
private static EventResolver createStringResolver() {
return (final LogEvent logEvent, final JsonWriter jsonWriter) -> resolveString(null, logEvent, jsonWriter);
}

private static void resolveString(final String fallbackKey, final LogEvent logEvent, final JsonWriter jsonWriter) {
Expand Down

0 comments on commit 40d18b1

Please sign in to comment.