Disable OnStartupTriggeringPolicy tests on UNIX

apache · May 20, 2024 · 7b92b6f · 7b92b6f
1 parent a15240f
commit 7b92b6f
Show file tree

Hide file tree

Showing 3 changed files with 42 additions and 2 deletions.
diff --git a/...st/java/org/apache/logging/log4j/core/appender/rolling/OnStartupTriggeringPolicyTest.java b/...st/java/org/apache/logging/log4j/core/appender/rolling/OnStartupTriggeringPolicyTest.java
@@ -18,6 +18,7 @@
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assumptions.assumeTrue;
 
 import java.io.ByteArrayInputStream;
 import java.io.InputStream;
@@ -68,6 +69,19 @@ public void testPolicy() throws Exception {
         final FileTime fileTime = FileTime.fromMillis(timeStamp);
         final BasicFileAttributeView attrs = Files.getFileAttributeView(target, BasicFileAttributeView.class);
         attrs.setTimes(fileTime, fileTime, fileTime);
+
+        /*
+         * POSIX does not define a file creation timestamp.
+         * Depending on the system `creationTime` might be:
+         *  * 0,
+         *  * the last modification time
+         *  * or the time the file was actually created.
+         *
+         * This test fails if the latter occurs, since the file is created after the JVM.
+         */
+        final FileTime creationTime = attrs.readAttributes().creationTime();
+        assumeTrue(creationTime.equals(fileTime) || creationTime.toMillis() == 0L);
+
         final PatternLayout layout = PatternLayout.newBuilder()
                 .withPattern("%msg")
                 .withConfiguration(configuration)

diff --git a/...est/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderOnStartupTest.java b/...est/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderOnStartupTest.java
@@ -17,6 +17,7 @@
 package org.apache.logging.log4j.core.appender.rolling;
 
 import static org.junit.Assert.assertTrue;
+import static org.junit.jupiter.api.Assumptions.assumeTrue;
 
 import java.nio.file.DirectoryStream;
 import java.nio.file.Files;
@@ -52,7 +53,19 @@ public static void setup() throws Exception {
         final Path target = loggingPath.resolve(FILENAME);
         Files.copy(Paths.get(SOURCE, FILENAME), target, StandardCopyOption.COPY_ATTRIBUTES);
         final FileTime newTime = FileTime.from(Instant.now().minus(1, ChronoUnit.DAYS));
-        Files.getFileAttributeView(target, BasicFileAttributeView.class).setTimes(newTime, newTime, newTime);
+        final BasicFileAttributeView attrs = Files.getFileAttributeView(target, BasicFileAttributeView.class);
+        attrs.setTimes(newTime, newTime, newTime);
+        /*
+         * POSIX does not define a file creation timestamp.
+         * Depending on the system `creationTime` might be:
+         *  * 0,
+         *  * the last modification time
+         *  * or the time the file was actually created.
+         *
+         * This test fails if the latter occurs, since the file is created after the JVM.
+         */
+        final FileTime creationTime = attrs.readAttributes().creationTime();
+        assumeTrue(creationTime.equals(newTime) || creationTime.toMillis() == 0L);
     }
 
     @Test

diff --git a/.../test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderRestartTest.java b/.../test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderRestartTest.java
@@ -23,6 +23,7 @@
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.junit.jupiter.api.Assertions.fail;
+import static org.junit.jupiter.api.Assumptions.assumeTrue;
 
 import java.io.File;
 import java.io.IOException;
@@ -68,7 +69,19 @@ public static void setup() throws Exception {
         Files.createDirectories(DIR);
         Files.write(FILE, "Hello, world".getBytes(), StandardOpenOption.CREATE);
         final FileTime newTime = FileTime.from(Instant.now().minus(2, ChronoUnit.DAYS));
-        Files.getFileAttributeView(FILE, BasicFileAttributeView.class).setTimes(newTime, newTime, newTime);
+        final BasicFileAttributeView attrs = Files.getFileAttributeView(FILE, BasicFileAttributeView.class);
+        attrs.setTimes(newTime, newTime, newTime);
+        /*
+         * POSIX does not define a file creation timestamp.
+         * Depending on the system `creationTime` might be:
+         *  * 0,
+         *  * the last modification time
+         *  * or the time the file was actually created.
+         *
+         * This test fails if the latter occurs, since the file is created after the JVM.
+         */
+        final FileTime creationTime = attrs.readAttributes().creationTime();
+        assumeTrue(creationTime.equals(newTime) || creationTime.toMillis() == 0L);
     }
 
     @AfterClass