Exceptions are ignored even with ignoreExceptions="false" when booting #1445
Milestone
Comments
david0
changed the title
|
I'm experiencing this bug as well; I believe the fix is around here return true;it should be: return success; |
|
The You are right, that method should return |
|
@ppkarwasz PR created: #1549. |
vy
added a commit
that referenced
this issue
Oct 6, 2023
LuciferYang
added a commit
to apache/spark
that referenced
this issue
Oct 23, 2023
### What changes were proposed in this pull request? This pr aims upgrade log4j from 2.20.0 to 2.21.0. ### Why are the changes needed? Support for the zstd compression algorithm has been added in the new version: apache/logging-log4j2#1508 | apache/logging-log4j2#1514 Meanwhile, the new version starts to use Java 11 for building, and the runtime version is still compatible with Java 8: apache/logging-log4j2#1369 The new version also brings some bug fixes, such as: - Fixed logging of java.sql.Date objects by appending it before Log4J tries to call java.util.Date.toInstant() on it: apache/logging-log4j2#1366 - Fixed concurrent date-time formatting issue in PatternLayout: apache/logging-log4j2#1485 - Fixed buffer size in Log4jFixedFormatter date time formatter: apache/logging-log4j2#1418 - Fixed the propagation of synchronous action failures in RollingFileManager and FileRenameAction: apache/logging-log4j2#1445 | apache/logging-log4j2#1549 - Fixed RollingFileManager to propagate failed synchronous actions correctly: apache/logging-log4j2#1445 and more. The complete release note is as follows: - https://github.com/apache/logging-log4j2/releases/tag/rel%2F2.21.0 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes #43478 from LuciferYang/SPARK-45625. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: yangjie01 <yangjie01@baidu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
We have an rolling file appender with
ignoreExceptions="false"andimmediateFlush="true"so that in case of any problem with this appender we would expect exceptions.That works fine for the running application but if the appenders files are not writable during application boot, there are error messages but they are just logged and not thrown. Hence the applications starts "successfully" but with a malfunctioning logging (missing loggers)
I would expect that errors during boot time are thrown if
ignoreExceptionsis failseConfiguration
Version: 2.19.0
Operating system: Mac OS/X 13.3.1
JDK: OpenJDK Runtime Environment Corretto-17.0.3.6.1 (build 17.0.3+6-LTS)
Logs
Reproduction
using this:
example.tar.gz
The text was updated successfully, but these errors were encountered: