LOG4J2-2091: Log4j respects the configured "log4j2.is.webapp" property #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR looks good, though could you associate this with a JIRA ticket? Also, a unit test would be great to help avoid this bug from resurfacing in the future. Thanks! |
carterkozak
changed the title
|
Hi @jvz, thanks for the quick reply! I've added a jira ticket, but I'm not sure the best way to add real tests for this given how this is configured as static state. Any chance you could point me in the right direction? |
|
I think you could add a simple test in log4j-web that asserts |
Some applications run embedded servlet containers sharing a single logging context from the root application.
carterkozak
force-pushed
the
is_webapp
branch
from
e5f18e5
to
b564184
Compare
|
Updated, thanks for the feedback! |
|
Looks great, thanks! Anyone else on the team is welcome to merge this as I won't be around an appropriate computer until tomorrow at the earliest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some applications run embedded servlet containers sharing
a single logging context from the root application.