Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReusableMessage implementations no longer allocate for 0-len params #149

Closed
wants to merge 2 commits into from
Closed

ReusableMessage implementations no longer allocate for 0-len params #149

wants to merge 2 commits into from

Conversation

carterkozak
Copy link
Contributor

No description provided.

@carterkozak carterkozak force-pushed the reusable_message_getparams_allocation branch from a62583c to 0f6ac85 Compare February 14, 2018 19:09
@garydgregory
Copy link
Member

Thank you for the PR. That's a lot of duplicated code (relatively). Can the empty array and new expression be refactored in a common site?

@carterkozak carterkozak force-pushed the reusable_message_getparams_allocation branch from 0f6ac85 to 475fb6a Compare February 14, 2018 21:57
@carterkozak carterkozak force-pushed the reusable_message_getparams_allocation branch from 475fb6a to d396ed4 Compare February 14, 2018 22:02
@carterkozak
Copy link
Contributor Author

Yep, updated.

@carterkozak carterkozak mentioned this pull request Feb 20, 2018
Closed
@carterkozak
Copy link
Contributor Author

This isn't as important to me now that we have #150
I can rebase this PR if you think it's still helpful, otherwise feel free to close it out!

@carterkozak carterkozak closed this Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carterkozak @garydgregory