Set the default minLevel and maxLevel of LevelRangeFilter
#1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…FF` and `ALL`, respectively
vy
force-pushed
the
LevelRangeFilter-defaults
branch
from
0a097b4
to
91cb61b
Compare
ppkarwasz
approved these changes
Jun 5, 2023
Comment on lines
+78
to
+79
| @PluginAttribute("onMatch") final Result onMatch, | ||
| @PluginAttribute("onMismatch") final Result onMismatch) { |
There was a problem hiding this comment.
We might take this opportunity to switch to the builder pattern. AbstractFilter.AbstractFilterBuilder has already defaults for onMatch and onMismatch.
There was a problem hiding this comment.
I have indeed seen that TODO and checked it. Though the required LoC doubles. Hence, sticked to this version.
|
LGTM |
garydgregory
approved these changes
Jun 6, 2023
vy
added a commit
that referenced
this pull request
Jun 6, 2023
jvz
pushed a commit
to jvz/logging-log4j2
that referenced
this pull request
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default
minLevelandmaxLevelofLevelRangeFilterare both set toERROR. As hinted in #1495, this is unintuitive and excludesFATALby default, unlessminLevelis explicitly overridden. This PR replaces these defaults withOFFandALL, respectively, and adds documentation.Warning! This change breaks the backward compatibility. Though the expected impact is low, since
maxLevel. This will still work, yet, after this PR, the filter will also allow events with levels higher than ERROR.