Removes support for EventData
#2076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have two doubts about the support for
|
vy
added
bug
|
@ppkarwasz, LGTM. I support the idea of removing |
The `org.slf4j.ext.EventData` class was a primitive equivalent of Log4j's `StructuredDataMessage`. QOS.CH published CVE-2018-8088 against this class and removed it from `slf4j-ext` version 1.7.26. For a long time we kept support code to convert `EventData` to its Log4j equivalent for compatibility's sake: users that relied on this class could still use Log4j Core, but the functionality was **automatically** disabled once they upgraded `slf4j-ext`. Since 5 years passed since `slfj4-ext` 1.7.26 was published, we can safely assume that all the users upgraded the library and the support code can be removed.
After the removal of `EventData`, the only usage of `slf4j-ext` was in tests. However, since all `slf4j-ext` method calls delegate to `slfj4-api` method calls there is no sense in testing it directly.
ppkarwasz
force-pushed
the
remove-event-data
branch
from
c422a70
to
0bfbc15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
org.slf4j.ext.EventDataclass was a primitive equivalent of Log4j'sStructuredDataMessage. QOS.CH published CVE-2018-8088 against this class and removed it fromslf4j-extversion 1.7.26.For a long time we kept support code to convert
EventDatato its Log4j equivalent for compatibility's sake: users that relied on this class could still use Log4j Core, but the functionality was automatically disabled once they upgradedslf4j-ext.Since 5 years passed since
slfj4-ext1.7.26 was published, we can safely assume that all the users upgraded the library and the support code can be removed.