Move async support to log4j-async-logger
#2241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppkarwasz
force-pushed
the
move-async
branch
2 times, most recently
from
de345cc
to
2b22eea
Compare
We move all the tests using `AsyncLogger` and `AsyncLoggerConfig` from `log4j-core-test` to a new artifact `log4j-async-logger` in preparation for splitting async support out of `log4j-core`.
This PR removes all occurences of `instanceof Async*` that might prevent the separation of the async support. The removal requires a couple of new API methods and binary incompatible changes.
A couple more tests require changes to be independent from async loggers and logger configurations. The `CoreContextSelectors` class is not used, so we remove it.
This moves the main code for `AsyncLogger` and `AsyncLoggerConfig` to `log4j-async-logger`. Further tasks such as proper encapsulation into internal packages and removal of the optional dependency guards, will be performed in a future task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
AsyncLoggerandAsyncLoggerConfigclasses fromlog4j-coreto a separatelog4j-async-loggerartifact. It is part of #2163.log4j-async-logger,log4j-async-logger#2248