Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove log4j-jcl and log4j-appserver modules #2257

Merged
merged 2 commits into from Jan 29, 2024
Merged

Conversation

vy
Copy link
Member

@vy vy commented Jan 29, 2024

This PR removes log4j-jcl and log4j-appserver as agreed in the mailing list.

@vy vy added this to the 3.0.0 milestone Jan 29, 2024
@vy vy self-assigned this Jan 29, 2024
@vy vy requested a review from ppkarwasz January 29, 2024 19:34
Copy link
Contributor

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Regarding the documentation for log4j-jcl, we can add somewhere that it was replaced by commons-logging:commons-logging:1.3.0.

src/site/asciidoc/faq.adoc Show resolved Hide resolved
@vy
Copy link
Member Author

vy commented Jan 29, 2024

Looks good to me.

@ppkarwasz, thanks so much for the review! 🙏

Regarding the documentation for log4j-jcl, we can add somewhere that it was replaced by commons-logging:commons-logging:1.3.0.

I thought exactly the same while updating docs. They need to be and will be rewritten before 3.0.0 anyway.

@vy vy merged commit c861f05 into main Jan 29, 2024
9 checks passed
@vy vy deleted the main-remove-jcl-and-appserver branch January 29, 2024 20:53
@ppkarwasz ppkarwasz removed this from the 3.0.0 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants