Fix issue #2363: Extract Throwable should be irrelevant to the count of patternAnalysis

[SeasonPanPan]

Fix issue #2363: Extract Throwable should be irrelevant to the count of patternAnalysis

[SeasonPanPan]

Hello, for this issue, I have some questions about it, the first modification is to keep the original judgment of the count of parameters and placeholders, and change args.length > analysis.placeholderCount to args.length >= analysis.placeholderCount, but I also thought that if the user sets the last parameter to an exception, it is more appropriate to print out the exception stack, It has nothing to do with the count of placeholders.

I hope that teachers can explain the intent of this code?

[ppkarwasz]

I like the idea of using the last parameter as Throwable (and removing it from the parameter list), whenever possible, but this constitutes a breaking change.

You can achieve the same effect implementing a separate MessageFactory2.

[SeasonPanPan]

@ppkarwasz I got your point, thank you.