Log4 j2 913 - Add support for HTTP/S configuration monitoring. Support Spring Cloud Config #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfig LOG4J2-913 - App works with Cloud Config LOG4j2-913 - Integration with Spring Cloud Config
jvz
requested changes
Jan 25, 2019
log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationFactory.java
Show resolved
Hide resolved
| * @param url the URL where the input stream originated | ||
| * @param lastModified when the source was last modified. | ||
| */ | ||
| public ConfigurationSource(final InputStream stream, final URL url, long lastModified) { |
There was a problem hiding this comment.
So I'll note here that for 3.x, we should certainly be redoing this API. It exposes way too much internal state.
There was a problem hiding this comment.
Good luck with that. All this information has to be passed from one configuration to another to allow reconfiguration to occur.
There was a problem hiding this comment.
I've considered in the past porting over or implementing a subset of the Resource interface from Spring. Do you think such an API would be more useful than having to inspect the ConfigurationSource union-like class?
log4j-core/src/main/java/org/apache/logging/log4j/core/config/HttpWatcher.java
Show resolved
Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/net/ssl/SslConfigurationFactory.java
Show resolved
Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/util/Watcher.java
Show resolved
Hide resolved
log4j-core/src/test/java/org/apache/logging/log4j/core/util/WatchHttpTest.java
Show resolved
Hide resolved
log4j-core/src/test/java/org/apache/logging/log4j/core/util/WatchHttpTest.java
Show resolved
Hide resolved
...java/org/apache/logging/log4j/spring/cloud/config/client/Log4j2CloudConfigLoggingSystem.java
Show resolved
Hide resolved
.../org/apache/logging/log4j/spring/cloud/config/server/controller/Log4jResourceController.java
Show resolved
Hide resolved
.../org/apache/logging/log4j/spring/cloud/config/server/controller/Log4jResourceController.java
Show resolved
Hide resolved
jvz
approved these changes
Feb 5, 2019
carterkozak
reviewed
Feb 5, 2019
| @@ -50,6 +50,7 @@ private CompositeTriggeringPolicy(final TriggeringPolicy... triggeringPolicies) | |||
| @Override | |||
| public void initialize(final RollingFileManager manager) { | |||
| for (final TriggeringPolicy triggeringPolicy : triggeringPolicies) { | |||
| LOGGER.debug("Initializing triggering policy ", triggeringPolicy.toString()); | |||
There was a problem hiding this comment.
nit: I don't think toString isn't necessary here, the logger will get the string value if debug is enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For your initial review. I still need to update the web site and look into spring cloud push notifications, so don't merge this yet.