Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve api.adoc et al. #2604

Merged
merged 14 commits into from
May 24, 2024
Merged

Improve api.adoc et al. #2604

merged 14 commits into from
May 24, 2024

Conversation

vy
Copy link
Member

@vy vy commented May 22, 2024

Fixes following tickets:

Reviewer notes

  • Reviewers are recommended to checkout the branch locally, build, and view it.
  • Except trivial typo/grammar fixes, do not push content changes to the branch, instead drop a comment to the associated parts of the source, please.

@vy vy marked this pull request as draft May 22, 2024 12:17
ppkarwasz
ppkarwasz requested changes May 22, 2024
View reviewed changes
Copy link
Contributor

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

src/site/antora/modules/ROOT/partials/manual/api-intro.adoc Outdated Show resolved Hide resolved
src/site/antora/modules/ROOT/partials/manual/api-intro.adoc Show resolved Hide resolved
src/site/antora/modules/ROOT/partials/manual/api-intro.adoc Outdated Show resolved Hide resolved
src/site/antora/modules/ROOT/partials/manual/api-best-practice-dont-use-toString.adoc Show resolved Hide resolved
src/site/antora/modules/ROOT/partials/manual/api-best-practice-exception-as-last-argument.adoc Outdated Show resolved Hide resolved
src/site/antora/modules/ROOT/partials/manual/api-best-practice-use-supplier.adoc Show resolved Hide resolved
src/site/antora/modules/ROOT/pages/manual/api.adoc Show resolved Hide resolved
src/site/antora/modules/ROOT/pages/manual/api.adoc Show resolved Hide resolved
@vy vy mentioned this pull request May 23, 2024
Merged
@vy vy marked this pull request as ready for review May 24, 2024 08:11
@vy vy merged commit e214a04 into 2.x May 24, 2024
6 checks passed
@vy vy deleted the doc/2.x/api branch May 24, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppkarwasz ppkarwasz ppkarwasz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vy @ppkarwasz