Log4j 1.2 bridge uses the wrong file pattern for rolling file appenders #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ppkarwasz |
ppkarwasz
force-pushed
the
rolling-file-appender
branch
from
0824d6e
to
3c09a93
Compare
|
@garydgregory: done. |
Changes property resolution used by `Log4j1ConfigurationParser` to Log4j 1.x `OptionConverter` to be in line with the other two configuration factories.
ppkarwasz
force-pushed
the
rolling-file-appender
branch
from
3c09a93
to
c62e971
Compare
garydgregory
changed the title
garydgregory
changed the title
garydgregory
changed the title
asfgit
pushed a commit
that referenced
this pull request
Jan 20, 2022
asfgit
pushed a commit
that referenced
this pull request
Jan 20, 2022
|
@ppkarwasz
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Log4j 1.x bridge incorrectly sets the pattern of the rolling file appenders. Moreover the
RollingFileAppenderdid not have a time based triggering policy in the original Log4j 1.x.The triggering policies in this PR are configured in the same way as in the
Log4j1ConfigurationFactory, i.e. with a uselessCompositeTriggeringPolicy.This PR is linked with the tests in #706.