Provide a uniform Log4j 1.x message factory #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppkarwasz
commented
Feb 21, 2022
| ((ExtendedLogger) logger).logMessage(fqcn, lvl, null, msg, t); | ||
| } else { | ||
| final ObjectRenderer renderer = get(message.getClass()); | ||
| final Message msg = message instanceof Message ? (Message) message | ||
| : renderer != null ? new RenderedMessage(renderer, message) : new ObjectMessage(message); |
There was a problem hiding this comment.
The RenderedMessage case is omitted, since this would require a stateful MessageFactory (per category).
Anyway there is currently no way to add elements to the RendererMap.
ppkarwasz
force-pushed
the
log4j1-message-factory
branch
from
58ef81c
to
bdcf321
Compare
| * @param map a generic map | ||
| * @return a {@link StringMap} | ||
| */ | ||
| public static SortedArrayStringMap fromGenericMap(final Map<?, ?> map) { |
There was a problem hiding this comment.
I don't think this is needed, would you check your tests against HEAD, without any main changes?
There was a problem hiding this comment.
@garydgregory: after your fix it is not needed anymore.
This PR provides a factory method that decides the type of message based on the runtime type of the logged object (cf. [LOG4J2-3080]( https://issues.apache.org/jira/browse/LOG4J2-3080)). These are applied to both `maybeLog` and `forceLog`.
ppkarwasz
force-pushed
the
log4j1-message-factory
branch
from
bdcf321
to
2858c49
Compare
ppkarwasz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a factory method that decides the type of message based on the runtime type of the logged object (cf. LOG4J2-3080).
Before the implementations of
maybeLogandforcedLogcreated different types of messages.