Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solr pages to Pelican template #2

Merged
merged 21 commits into from
Nov 3, 2019
Merged

Conversation

adamwalz
Copy link
Contributor

@adamwalz adamwalz commented Nov 3, 2019

This PR adds the ability to build the solr pages at lucene.apache.org/solr with Pelican. This change gets to rough parity with the current production site. Upcoming changes are required to inspect each page individually to ensure 100% parity as well as to DRY the templates to reduce needless code duplication introduced as part of the migration.

See README.md for instructions on building locally

ctargett and others added 20 commits October 28, 2019 18:57
This allows for dynamically limiting the number of news items on
solr/news.html without removing old items from pages/solr/news.mdtext
@adamwalz
Copy link
Contributor Author

adamwalz commented Nov 3, 2019

Future PRs are expected to be smaller and easier to review, possibly with the exception of a refactoring PR to reduce code duplication.

@janhoy
Copy link
Contributor

janhoy commented Nov 3, 2019

The solr section looks good. Of course there are lots of duplication in the templates but you already know that. Do you want me to squash your merges since 9a8bfaf into one?

@adamwalz
Copy link
Contributor Author

adamwalz commented Nov 3, 2019

Squashing is up to you depending on the norms of the project. I've been trying to keep the commits logical so that each commit is buildable on its own and git blame can sort of describe the reasoning behind particular changes. If it were up to me I'd ask to rebase instead of squash.

@janhoy janhoy merged commit a013224 into apache:master Nov 3, 2019
@janhoy
Copy link
Contributor

janhoy commented Nov 3, 2019

Good, they are all logically laid out, and I merged now, to quickly be able to iterate on the finishing touches. Appreciate the nice work you do here!

@janhoy
Copy link
Contributor

janhoy commented Nov 11, 2019

Trying to link with LUCENE-9012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants