-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add solr pages to Pelican template #2
Conversation
git-svn-id: https://svn.apache.org/repos/asf/lucene/cms/trunk@1869087 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/lucene/cms/trunk@1869306 13f79535-47bb-0310-9956-ffa450edef68
git-svn-id: https://svn.apache.org/repos/asf/lucene/cms/trunk@1869309 13f79535-47bb-0310-9956-ffa450edef68
This allows for dynamically limiting the number of news items on solr/news.html without removing old items from pages/solr/news.mdtext
Future PRs are expected to be smaller and easier to review, possibly with the exception of a refactoring PR to reduce code duplication. |
The solr section looks good. Of course there are lots of duplication in the templates but you already know that. Do you want me to squash your merges since 9a8bfaf into one? |
Squashing is up to you depending on the norms of the project. I've been trying to keep the commits logical so that each commit is buildable on its own and |
Good, they are all logically laid out, and I merged now, to quickly be able to iterate on the finishing touches. Appreciate the nice work you do here! |
Trying to link with LUCENE-9012 |
This PR adds the ability to build the solr pages at lucene.apache.org/solr with Pelican. This change gets to rough parity with the current production site. Upcoming changes are required to inspect each page individually to ensure 100% parity as well as to DRY the templates to reduce needless code duplication introduced as part of the migration.
See README.md for instructions on building locally