Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cve 2020 13941 #29

Merged
merged 3 commits into from
Sep 12, 2020
Merged

Cve 2020 13941 #29

merged 3 commits into from
Sep 12, 2020

Conversation

dsmiley
Copy link
Contributor

@dsmiley dsmiley commented Sep 2, 2020

No description provided.

@dsmiley dsmiley requested a review from janhoy September 2, 2020 06:10
janhoy
janhoy reviewed Sep 2, 2020
View reviewed changes
Copy link
Contributor

@janhoy janhoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you follow the template of other reports, i.e. use the same headings, like Versions Affected and Mitigation?

@dsmiley
Copy link
Contributor Author

dsmiley commented Sep 3, 2020

Updated. I didn't add "Vendor" which seems pointless. Where did this template/convention come from?

janhoy
janhoy approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@janhoy janhoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@janhoy
Copy link
Contributor

janhoy commented Sep 11, 2020

The CVE template here I think is a copy of a kind of a layout some projects use for ANNOUNCE mails for CVEs, such as https://lists.apache.org/thread.html/rd48c72bd3255bda87564d4da3791517c074d94f8a701f93b85752651%40%3Cannounce.apache.org%3E, but I see that the style of those emails vary a lot. However, for the web site news it makes sense to keep the same structure since they are all listed in the same place.

The new CMS also has a possibility to define more "variables" on top of the template, so we could in theory define all CVE headings as structured metadata that could then be used in other templates such as the table on top of security page. But I think what we have now is a good balance?

@dsmiley dsmiley merged commit add1ece into apache:master Sep 12, 2020
@dsmiley dsmiley deleted the cve-2020-13941 branch September 13, 2020 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janhoy janhoy janhoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dsmiley @janhoy