Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-15215: SolrJ: Remove Netty dependency #2458

Closed
wants to merge 2 commits into from

Conversation

dsmiley
Copy link
Contributor

@dsmiley dsmiley commented Mar 5, 2021

Netty is an optional dependency of Zookeeper; one must opt-in to use it.
Netty remains a solr-core dependency transitively via Hadoop/HDFS.

https://issues.apache.org/jira/browse/SOLR-15215

Netty is an *optional* dependency of Zookeeper; one must opt-in to use it.
Netty remains a solr-core dependency transitively via Hadoop/HDFS.
@dsmiley dsmiley requested review from dweiss and madrob March 5, 2021 15:10
Copy link
Contributor

@dweiss dweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... if it compiles and tests! :)

@janhoy
Copy link
Contributor

janhoy commented Mar 5, 2021

I put them in https://issues.apache.org/jira/browse/SOLR-13665. And the reason was to enable secure connections with Zookeeper.

  • To be able to use secure solr-zk communication with SSL, netty libs are needed on client side
  • Solr hosts themselves use solrj to talk to zookeeper, so they need to be available on the host

See https://issues.apache.org/jira/browse/SOLR-7893 for plans to document how to enable this. If netty is not shipped with Solr, then this needs to be a plugin. Actually I think this would make a good candidate for a package "solrj-zk-netty", which would simply contain the needed jar files and make them available to solrj, which can then talk SSL with Zookeeper.

Problem with removing it before we have an alternative ready is that people already rely on it, see https://issues.apache.org/jira/browse/SOLR-14027 which is a bug report about Admin UI ZK screen not working when using SSL against Zookeeper.

@dsmiley dsmiley closed this Aug 2, 2023
@itygh
Copy link

itygh commented Aug 2, 2023 via email

@dsmiley dsmiley deleted the solr-15215-solrj-netty branch August 2, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants