Make TestDrillSideways#testCollectionTerminated less strict (#12920)

apache · Dec 12, 2023 · cf13a92 · cf13a92
1 parent a6f70ad
commit cf13a92
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt
@@ -195,6 +195,9 @@ Bug Fixes
 * GITHUB#12558: Ensure #finish is called on all drill-sideways FacetsCollectors even when no hits are scored.
   (Greg Miller)
 
+* GITHUB#12920: Address bug in TestDrillSideways#testCollectionTerminated that could occasionally cause the test to
+  fail with certain random seeds. (Greg Miller)
+
 Other
 ---------------------
 

diff --git a/lucene/facet/src/test/org/apache/lucene/facet/TestDrillSideways.java b/lucene/facet/src/test/org/apache/lucene/facet/TestDrillSideways.java
@@ -326,10 +326,6 @@ public void collect(int doc) throws IOException {
         // termination occurs (i.e., #finish is properly called in that scenario):
         assertEquals(1, baseFC.getMatchingDocs().size());
         assertEquals(1, dimFC.getMatchingDocs().size());
-        FacetsCollector.MatchingDocs baseMD = baseFC.getMatchingDocs().get(0);
-        FacetsCollector.MatchingDocs dimMD = dimFC.getMatchingDocs().get(0);
-        assertEquals(1, baseMD.totalHits);
-        assertEquals(1, dimMD.totalHits);
       }
     }
   }