Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up ant compatability remnants in Gradle build [LUCENE-9435] #10475

Closed
asfimport opened this issue Jul 19, 2020 · 8 comments
Closed

Clean up ant compatability remnants in Gradle build [LUCENE-9435] #10475

asfimport opened this issue Jul 19, 2020 · 8 comments

Comments

@asfimport
Copy link

asfimport commented Jul 19, 2020

As per Dawid Weiss' comments in #10473, there will be some cleanup after the initial work is done.

Assigning it to myself, to track. @dweiss  please don't hesitate to reassign if you want.


Migrated from LUCENE-9435 by Erick Erickson (@ErickErickson), resolved Aug 30 2020
Linked issues:

@asfimport
Copy link
Author

Erick Erickson (@ErickErickson) (migrated from JIRA)

Hate it when I do that. I like 9475 better, it has tasks so closing.

@asfimport
Copy link
Author

ASF subversion and git services (migrated from JIRA)

Commit def82ab in lucene-solr's branch refs/heads/master from Dawid Weiss
https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=def82ab

LUCENE-9435: Clean up ant compatability remnants in Gradle build

  • Removing ant-only unused tasks.
  • Correct message in TestVersion.java
  • Remove unused file.
  • Removing forbidden API rules for ant.
  • Remove 'resolve' emulation.
  • Move ecj-lint to task-definition-relative folder.
  • Remove 'packaging' specification. It'll have to wait until proper new packaging is implemented for Solr distribution.
  • Move render-javadoc tasks's files to task-relative location.
  • Moved security manager policies and default JDK logging file to gradle's task relative locations.
  • Removing obsolete ant tools. Moving check source patterns under gradle's folder.
  • Correct paths.
  • Correct property name in task selector.

@asfimport
Copy link
Author

ASF subversion and git services (migrated from JIRA)

Commit def82ab in lucene-solr's branch refs/heads/LUCENE-9215 from Dawid Weiss
https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=def82ab

LUCENE-9435: Clean up ant compatability remnants in Gradle build

  • Removing ant-only unused tasks.
  • Correct message in TestVersion.java
  • Remove unused file.
  • Removing forbidden API rules for ant.
  • Remove 'resolve' emulation.
  • Move ecj-lint to task-definition-relative folder.
  • Remove 'packaging' specification. It'll have to wait until proper new packaging is implemented for Solr distribution.
  • Move render-javadoc tasks's files to task-relative location.
  • Moved security manager policies and default JDK logging file to gradle's task relative locations.
  • Removing obsolete ant tools. Moving check source patterns under gradle's folder.
  • Correct paths.
  • Correct property name in task selector.

@asfimport
Copy link
Author

Erick Erickson (@ErickErickson) (migrated from JIRA)

@dweiss  I think this broke "gradlew assemble", I get a bunch of:

Could not determine the dependencies of task ':solr:packaging:toDir'.
> Could not resolve all task dependencies for configuration ':solr:packaging:contrib'.
   > Could not resolve project :solr:contrib:analysis-extras.
     Required by:
         project :solr:packaging
      > Project :solr:packaging declares a dependency from configuration 'contrib' to configuration 'packaging' which is not declared in the descriptor for project :solr:contrib:analysis-extras.
   > Could not resolve project :solr:contrib:analytics.
     Required by:
         project :solr:packaging
      > Project :solr:packaging declares a dependency from configuration 'contrib' to configuration 'packaging' which is not declared 

I have to go out to an appointment now so can't dig for a couple of hours...

 

@asfimport
Copy link
Author

Dawid Weiss (@dweiss) (migrated from JIRA)

Indeed, it might have. That workaround wasn't the right way to do it anyway. I'll take a look.

@asfimport
Copy link
Author

ASF subversion and git services (migrated from JIRA)

Commit 4a2a2da in lucene-solr's branch refs/heads/master from Dawid Weiss
https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=4a2a2da

LUCENE-9435: revert Solr's packaging stuff for now.

@asfimport
Copy link
Author

Dawid Weiss (@dweiss) (migrated from JIRA)

I reverted the old hairy code (for Solr only) since it'll work for now.

@asfimport
Copy link
Author

Adrien Grand (@jpountz) (migrated from JIRA)

Closing after the 9.0.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants