Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to do test re-runs (suite duplication, so-called 'beasting') [LUCENE-9465] #10505

Closed
asfimport opened this issue Aug 16, 2020 · 5 comments

Comments

@asfimport
Copy link

asfimport commented Aug 16, 2020


Migrated from LUCENE-9465 by Dawid Weiss (@dweiss), resolved Aug 18 2020
Attachments: LUCENE-9465.patch
Linked issues:

Pull requests: apache/lucene-solr#1757

@asfimport
Copy link
Author

Dawid Weiss (@dweiss) (migrated from JIRA)

Added something that works, although I'm not too happy about it because it indeed doesn't run in parallel – this used to be possible but gradle somewhere lost the ability to run intra-project tasks in parallel... Strange.

The 'beast' task essentially duplicates test task's configuration multiple times over. You should pass '--tests' filter to restrict each run to the test (or suite) you're interested in. The 'tests' option is identical as in the regular 'test' task. Example:

gradlew -p lucene\core beast --tests TestPerFieldDocValuesFormat -Preps=2

I left some todos in the patch that point at alternative possibilities.

@asfimport
Copy link
Author

Dawid Weiss (@dweiss) (migrated from JIRA)

Filed a pull request with a simple 'beast' mode. This is pretty much an equivalent of what @rmuir suggested from within a shell script: it just re-runs the same test task sequentially over and over. The benefits may be that it reuses the same syntax for test filtering (--tests ...) and it "understands" when the randomization seed if fixed to one value vs. random in each test run.

This isn't ideal (no parallel execution) but works. To get parallelism with gradle's worker is a much more ambitious endeavor.

@asfimport
Copy link
Author

ASF subversion and git services (migrated from JIRA)

Commit 83ed210 in lucene-solr's branch refs/heads/master from Dawid Weiss
https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=83ed210

LUCENE-9465: 'beast' task from within gradle (#1757)

@asfimport
Copy link
Author

Dawid Weiss (@dweiss) (migrated from JIRA)

I allowed myself to add it in since there's been no feedback. I think it's better than nothing and it is nicely decoupled from anything else. If somebody has an idea for improving parallelism (maybe ask gradle folks) then it'd be great to know how to achieve it (pass an entire task to a gradle worker API).

@asfimport
Copy link
Author

Adrien Grand (@jpountz) (migrated from JIRA)

Closing after the 9.0.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants