You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Similar to what we did in #11415, let's reduce the public visibility of TaxonomyFacets and FloatTaxonomyFacets to pkg-private since they're really implementation details housing common logic and not really intended as extension points for user faceting.
PRs posted for this. The only point maybe worth calling out here for discussion is that the visibility reduction of TaxonomyFacets means there is no common type to refer to just taxonomy-faceting implementations. The only reason I could see this maybe mattering is that TaxonomyFacets defines public methods childrenLoaded() and siblingsLoaded()}. So it's possible some user wants to refer to taxonomy facets generally, but not as general as just referencing Facets because they want to rely on one of these methods. This seems unlikely to me. The only code we have that references these methods is in testing, but I suppose users might want to know if these things were loaded for the purpose of metrics/logging/etc.
Similar to what we did in #11415, let's reduce the
public
visibility ofTaxonomyFacets
andFloatTaxonomyFacets
to pkg-private since they're really implementation details housing common logic and not really intended as extension points for user faceting.Migrated from LUCENE-10440 by Greg Miller (@gsmiller), resolved Mar 01 2022
Pull requests: #712, #713
The text was updated successfully, but these errors were encountered: