Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce visibility of TaxonomyFacets and FloatTaxonomyFacets [LUCENE-10440] #11476

Closed
asfimport opened this issue Feb 24, 2022 · 4 comments
Closed

Comments

@asfimport
Copy link

asfimport commented Feb 24, 2022

Similar to what we did in #11415, let's reduce the public visibility of TaxonomyFacets and FloatTaxonomyFacets to pkg-private since they're really implementation details housing common logic and not really intended as extension points for user faceting.


Migrated from LUCENE-10440 by Greg Miller (@gsmiller), resolved Mar 01 2022
Pull requests: #712, #713

@asfimport
Copy link
Author

Greg Miller (@gsmiller) (migrated from JIRA)

PRs posted for this. The only point maybe worth calling out here for discussion is that the visibility reduction of TaxonomyFacets means there is no common type to refer to just taxonomy-faceting implementations. The only reason I could see this maybe mattering is that TaxonomyFacets defines public methods childrenLoaded() and siblingsLoaded()}. So it's possible some user wants to refer to taxonomy facets generally, but not as general as just referencing Facets because they want to rely on one of these methods. This seems unlikely to me. The only code we have that references these methods is in testing, but I suppose users might want to know if these things were loaded for the purpose of metrics/logging/etc.

@asfimport
Copy link
Author

ASF subversion and git services (migrated from JIRA)

Commit 4c9c1c0 in lucene's branch refs/heads/branch_9x from Greg Miller
https://gitbox.apache.org/repos/asf?p=lucene.git;h=4c9c1c0

LUCENE-10440: Mark TaxonomyFacets and FloatTaxonomyFacets as deprecated (#713)

@asfimport
Copy link
Author

ASF subversion and git services (migrated from JIRA)

Commit 51797dc in lucene's branch refs/heads/main from Greg Miller
https://gitbox.apache.org/repos/asf?p=lucene.git;h=51797dc

LUCENE-10440: Reduce visibility of TaxonomyFacets and FloatTaxonomyFacets (#712)

@asfimport
Copy link
Author

Adrien Grand (@jpountz) (migrated from JIRA)

Closing after the 9.1.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment