Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUCENE-10440: Reduce visibility of TaxonomyFacets and FloatTaxonomyFacets #712

Merged
merged 1 commit into from Mar 1, 2022

Conversation

gsmiller
Copy link
Contributor

@gsmiller gsmiller commented Feb 24, 2022

Description

These two classes are really implementation details, meant to hold common logic for our faceting implementations, but they are public and could be extended by users. It would be nice to reduce visibility to shrink our API surface area.

Solution

Make pkg-private. Also reduce visibility of protected methods/fields to pkg-private as a little extra cleanup. Note that I will mark these as @Deprecated on the 9x branch to provide advanced notice to any users that might be extending these.

Tests

No new testing needed.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Lucene maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant