Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestPackedInts.testPackedLongValues failing #13249

Closed
benwtrent opened this issue Mar 29, 2024 · 3 comments · Fixed by #13250
Closed

TestPackedInts.testPackedLongValues failing #13249

benwtrent opened this issue Mar 29, 2024 · 3 comments · Fixed by #13250
Labels
type:test

Comments

@benwtrent
Copy link
Member

Description

TestPackedInts.testPackedLongValues fails repeatably, example trace:

org.apache.lucene.util.packed.TestPackedInts > testPackedLongValues FAILED
    java.lang.AssertionError: expected:<2368> but was:<2384>
        at __randomizedtesting.SeedInfo.seed([E73C4D01E8CF65EC:E32957873BE4F660]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.junit.Assert.failNotEquals(Assert.java:835)
        at org.junit.Assert.assertEquals(Assert.java:647)
        at org.junit.Assert.assertEquals(Assert.java:633)
        at org.apache.lucene.util.packed.TestPackedInts.testPackedLongValues(TestPackedInts.java:1022)

Gradle command to reproduce

./gradlew :lucene:core:test --tests "org.apache.lucene.util.packed.TestPackedInts.testPackedLongValues" -Ptests.jvms=2 -Ptests.jvmargs= -Ptests.seed=E73C4D01E8CF65EC -Ptests.gui=true -Ptests.file.encoding=US-ASCII -Ptests.vectorsize=128
@benwtrent
Copy link
Member Author

Git bisect shows: c41eb22

#13232

@original-brownbear mind taking a look?

@original-brownbear
Copy link
Contributor

@benwtrent sure thing taking a look!

original-brownbear added a commit to original-brownbear/lucene that referenced this issue Mar 29, 2024
@original-brownbear
Fix ram estimate and its test for PackedInts.NullReader singleton
561982d 
Correct estimate for singleton to return `0` and use custom accumulator in tests to
fix assertions. Tried not doing this in apache#13232 but turns out we need a little complexity here
since the singleton is recognized by the `RamUsageTester` in so far that is only counted
once if it shows up repeatedly in an array or so.

fixes apache#13249
@original-brownbear original-brownbear mentioned this issue Mar 29, 2024
Merged
@original-brownbear
Copy link
Contributor

Here we go: #13250 turns out we need to be a little tricky here after all for singletons + ram estimation.

benwtrent pushed a commit that referenced this issue Apr 1, 2024
@original-brownbear
Fix ram estimate and its test for PackedInts.NullReader singleton (#1…
42f2da5 
…3250)

Correct estimate for singleton to return `0` and use custom accumulator in tests to
fix assertions. Tried not doing this in #13232 but turns out we need a little complexity here
since the singleton is recognized by the `RamUsageTester` in so far that is only counted
once if it shows up repeatedly in an array or so.

fixes #13249
benwtrent pushed a commit that referenced this issue Apr 1, 2024
@original-brownbear @benwtrent
Fix ram estimate and its test for PackedInts.NullReader singleton (#1…
dd9827f 
…3250)

Correct estimate for singleton to return `0` and use custom accumulator in tests to
fix assertions. Tried not doing this in #13232 but turns out we need a little complexity here
since the singleton is recognized by the `RamUsageTester` in so far that is only counted
once if it shows up repeatedly in an array or so.

fixes #13249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ram estimate and its test for PackedInts.NullReader singleton original-brownbear/lucene
2 participants
@benwtrent @original-brownbear