LUCENE-10644: Facets#getAllChildren testing should ignore child order #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuti-G
changed the title
gsmiller
reviewed
Jul 11, 2022
lucene/facet/src/test/org/apache/lucene/facet/FacetTestCase.java
Outdated
Show resolved
Hide resolved
|
Thanks @Yuti-G! This approach looks good to me. Is your plan to iterate on this PR to stop enforcing the ordering checks in all the tests? |
|
Yes, thanks @gsmiller for reviewing this new test approach! I will apply it to all the getAllChildren tests that I previously wrote. |
|
Sounds good. Thanks @Yuti-G! |
|
Hi @gsmiller, thanks for your previous review, and I have applied the changes to all the |
gsmiller
reviewed
Aug 17, 2022
lucene/facet/src/test/org/apache/lucene/facet/range/TestRangeFacetCounts.java
Outdated
Show resolved
Hide resolved
lucene/facet/src/test/org/apache/lucene/facet/range/TestRangeFacetCounts.java
Outdated
Show resolved
Hide resolved
lucene/facet/src/test/org/apache/lucene/facet/range/TestRangeFacetCounts.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
getAllChildrenunit tests to compare labels and values with no assumption about the child ordering. This pr only fixed some of the unit tests, and will continue to fix all of them after receiving feedback on this initial attempt. Thanks!Jira: https://issues.apache.org/jira/browse/LUCENE-10644