LUCENE-10657: CopyBytes now saves one memory copy on ByteBuffersDataOutput #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eDoc -> bufferdDocs.copyBytes(DataInput input) Abstract method copyBytes need to copy from input to a buffer and then write into ByteBuffersDataOutput, i think there is unnecessary, we can override it, copy directly from input into output
jpountz
reviewed
Jul 18, 2022
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java
Outdated
Show resolved
Hide resolved
1. Add UnitTest For ByteBuffersDataOutput.copyBytes
Thanks for your review, in commits 926dd i added check for the direct memory, and i added unit tests for different allocator in copyBytes |
jpountz
approved these changes
Jul 18, 2022
luyuncheng
changed the title
@jpountz Thanks for your review and suggestions, I have been updated the CHANGES entry |
uschindler
requested changes
Jul 18, 2022
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java
Outdated
Show resolved
Hide resolved
uschindler
requested changes
Jul 18, 2022
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java
Outdated
Show resolved
Hide resolved
2. Fixed currentBlock array type check
uschindler
approved these changes
Jul 18, 2022
jpountz
pushed a commit
that referenced
this pull request
Jul 19, 2022
…utput (#1034) Abstract method copyBytes need to copy from input to a buffer and then write into ByteBuffersDataOutput, i think there is unnecessary, we can override it, copy directly from input into output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is derived from LUCENE-10627 at #987
Jira: https://issues.apache.org/jira/browse/LUCENE-10657
The abstract method
copyBytesin DataOutput have to copy from input to a copyBuffer and then write into ByteBuffersDataOutput.blocks, i think there is unnecessary, we can override it, copy directly from input into output.with override this method, we can:
Lucene90CompressingStoredFieldsWriter#copyOneDoc->bufferdDocs.copyBytes(DataInput input)Lucene90CompoundFormat.writeCompoundFile->data.copyByteswhen input isBufferedChecksumIndexinputand output isByteBuffersDataOutputIndexWriter#copySegmentAsIs->CopyFrom -> copyBytes