Fix classloading deadlock in analysis factories / AnalysisSPILoader initialization #11718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nitialization. This closes apache#11701
|
This fix is more or less a copy of the SPI loader code we use in Codec, PostingsFormat, DocValuesFormat,... The general issue is: Nowhere in Java you should have a static initializer in a superclass that initializes instances of subclasses. This will deadlock if two threads load different subclasses at same time. See discussions in older issues about this. We had the same issue also with TermsEnum that @danmuzi found. The problem was not yet visible in Elasticsearch as the analysis factories are not used there in the same way like codecs components. We should still fix this, the issue #11701 was marked as critical. |
rmuir
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11701 (LUCENE-10665).