Use ByteArrayComparator to replace Arrays#compareUnsigned in some other places #11880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ldQuery and CheckIndex
gf2121
changed the title
gf2121
changed the title
jpountz
approved these changes
Nov 11, 2022
| import org.apache.lucene.util.StringHelper; | ||
| import org.apache.lucene.util.SuppressForbidden; | ||
| import org.apache.lucene.util.Version; | ||
| import org.apache.lucene.util.*; |
There was a problem hiding this comment.
Can you undo this star import?
|
@gf2121 Let's merge this PR? |
|
@jpountz Sorry for being late, thank you for the review ! I'll merge this |
gf2121
added a commit
to gf2121/lucene
that referenced
this pull request
Dec 8, 2022
gf2121
added a commit
that referenced
this pull request
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #11876 I find some other codes are still using
Arrays#compareUnAssignedwhich can be repaced byByteArrayComparatororArrayUtil#compareUnsigned4.This PR replaced some of them that look performance sensitive.