Add exponential growth to TimeLimitingBulkScorer #11984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpountz
reviewed
Nov 29, 2022
| expectedInterval = lastInterval; | ||
| } | ||
| // keep going or finish the test? | ||
| return --runs == 0 ? DocIdSetIterator.NO_MORE_DOCS : 0; |
There was a problem hiding this comment.
Why would we end prematurely instead of doing the checks on the full range? Is it to avoid the corner case of the last range, which might be smaller than the expected interval? Maybe the bulk scorer could record the segment's maxDoc and allow the difference to be less than expectedInterval if the max doc is equal to maxDoc?
jpountz
approved these changes
Nov 30, 2022
Done. |
jpountz
approved these changes
Dec 2, 2022
|
Thanks @costin! |
jpountz
pushed a commit
that referenced
this pull request
Dec 14, 2022
Increase the timeout check inside TimeLimitBulkScorer at exponential rate. Fix #11676
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the timeout check inside TimeLimitBulkScorer at exponential rate.
Fix #11676