Deprecate TermInSetQuery#getTermData #12173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uschindler
approved these changes
Mar 1, 2023
gsmiller
added a commit
that referenced
this pull request
Mar 1, 2023
gsmiller
added a commit
that referenced
this pull request
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TermInSetQuery#getTermDatais effectively leaking our internal encoding of the query terms, which will prevent us from changing this in the future if we want to. Nothing in our code relies on this right now, and I think we ought to remove it. If users really need to get the terms, they can keep track of them (they provide them in the first place) in whatever encoding they like. If there's really a need to go beyond this, we could expose some sort ofIterator<BytesRef>method. But let's stop exposing thePrefixCodedTermsinstance directly.Note: I will remove the method completely on
mainbut mark deprecated on9xas this PR demonstrates.