Fix ordered intervals query and add test case #12214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongyuyan97
changed the title
|
Oh, good catch! I ran a quick experiment to see if this also fixes the bug in LUCENE-9418 but we do unfortunately need to keep the extra minimization boolean. But this is still all good, and the test is great. Could you add an entry to CHANGES.txt? For now we'll target 9.6.0 as I don't think there's a 9.5.1 bugfix release planned, but we can always backport if one comes up. |
|
Thank you for your quick reply! I added an entry to Lucene 9.6.0 bug fixes. |
|
Thanks @hongyuyan97! |
asfgit
pushed a commit
that referenced
this pull request
Mar 27, 2023
Given an input text 'A B A C A B C' and search ORDERED(A, B, C), we should retrieve hits [0,3] and [4,6]; currently [4,6] is skipped. After finding the first interval [0, 3], the subintervals will become A[0,0], B[1,1], C[3,3]; then the algorithm will try to minimize it and the subintervals will become: A:[2,2], B:[5,5], C:[3,3] (after finding 5 > 3 it breaks the minimization) And when finding next interval, it will do advance(B) before checking whether it is after A(the do-while loop), so subintervals will become A[2,2], B[inf, inf], C[3,3] and return NO_MORE_INTERVAL. This commit instead continues advancing subintervals from where the last `nextInterval` call stopped, rather than always advancing all subintervals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to address issue #12213 Ordered intervals over interleaved terms.
A more detailed explanation of the issue and the reasoning behind the fix can be found in the report link above.