Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checks in KNNVectorField / KNNVectorQuery to only allow non-null, non-empty and finite vectors #12281

Merged
merged 8 commits into from
Jun 13, 2023
Merged

Add checks in KNNVectorField / KNNVectorQuery to only allow non-null, non-empty and finite vectors #12281

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
90aea15
improve NeighborArray assert message when results do not sort correctly
jbellis Jun 9, 2023
c9b3cb8
add checkFinite and fix TestExitableDirectoryReader (cosine taken wit…
jbellis Jun 9, 2023
113c4ad
revert changes to VUDefaultProvider; add checkFinite to VectorUtil in…
jbellis Jun 10, 2023
f000928
Check vector parameters to be finite in KnnFloat types and queries
uschindler Jun 11, 2023
942536b
improve javadocs
uschindler Jun 11, 2023
2dc8484
Make sure the last multiplication of norms are explicitly using doubl…
uschindler Jun 12, 2023
0bde969
Add length check for the constructor that does not create a new field…
uschindler Jun 12, 2023
0ab0be6
Add CHANGES.txt
uschindler Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion lucene/core/src/java/org/apache/lucene/document/KnnByteVectorField.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,12 @@ public KnnByteVectorField(String name, byte[] vector, FieldType fieldType) {
+ " using byte[] but the field encoding is "
+ fieldType.vectorEncoding());
}
fieldsData = Objects.requireNonNull(vector, "vector value must not be null");
Objects.requireNonNull(vector, "vector value must not be null");
if (vector.length != fieldType.vectorDimension()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

throw new IllegalArgumentException(
"The number of vector dimensions does not match the field type");
}
fieldsData = vector;
}

/** Return the vector value of this field */
Expand Down
8 changes: 6 additions & 2 deletions lucene/core/src/java/org/apache/lucene/document/KnnFloatVectorField.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,12 @@ public KnnFloatVectorField(String name, float[] vector, FieldType fieldType) {
+ " using float[] but the field encoding is "
+ fieldType.vectorEncoding());
}
fieldsData =
VectorUtil.checkFinite(Objects.requireNonNull(vector, "vector value must not be null"));
Objects.requireNonNull(vector, "vector value must not be null");
if (vector.length != fieldType.vectorDimension()) {
throw new IllegalArgumentException(
"The number of vector dimensions does not match the field type");
}
fieldsData = VectorUtil.checkFinite(vector);
}

/** Return the vector value of this field */
Expand Down