move CSVUtil to common from analyzer nori and kuromoji #12390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanvodita
approved these changes
Jul 18, 2023
mikemccand
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Looks great, thanks @twosom! A nice refactoring to combine two forked impls ... I'll merge!
|
I merged to main but there are quite a few conflicts on backport to 9.x -- any chance you could open a backport PR @twosom? Thanks! |
rmuir
pushed a commit
to rmuir/lucene
that referenced
this pull request
Nov 2, 2023
OK! I'll open backport PR ASAP! Thanks! |
javanna
added a commit
to elastic/elasticsearch
that referenced
this pull request
Nov 9, 2023
IndexDiskUsageAnalyzer and IndexDiskUsageAnalyzerTests, as well as CompletionFieldMapper, CompletionFieldMapperTests and CompletionStatsCacheTests need adjusting after apache/lucene#12741 , to refer to the latest postings format. KuromojiTokenizerFactory needs adjusting after apache/lucene#12390
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the
CSVUtilclass that existed separately in the AnalyzerNoriandKuromojito the module:analysis:common.By consolidating the
CSVUtilclass, we can prevent duplication and improve maintainability across the AnalyzerNoriandKuromoji.Closes #12389