Replace consecutive close() calls and close() calls with null checks with IOUtils.close() #12428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanvodita
approved these changes
Jul 18, 2023
|
LGTM as well. Thanks @shubhamvishu! |
gsmiller
approved these changes
Jul 29, 2023
|
@shubhamvishu apologies. I realized I marked this approved but never merged it. I'm happy to help merge this change, but would you mind adding a small note in CHANGES? |
…with IOUtils.close()
|
@gsmiller I have added the CHANGES entry under 9.8.0 and replaced a couple of more such calls I could find. Let me know if this looks good. Thanks! |
gsmiller
pushed a commit
that referenced
this pull request
Aug 17, 2023
…with IOUtils.close() (#12428)
|
Merged and back-ported. Thanks @shubhamvishu ! |
|
I would be curious to see the impact on performance here |
|
@madrob I don't think this change would be performance impacting as such though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces :
close()calls withIOUtils.close()to close multipleCloseables'IOUtils.close()Tests
./gradlew check