hunspell: make the hash table load factor customizable #12464
Conversation
| * usage. | ||
| */ | ||
| protected static double hashFactor() { | ||
| return 1.0; |
There was a problem hiding this comment.
Sorry for the dumb question but how can this be increased without bytecode manipulation or source code changes?
There was a problem hiding this comment.
Ouch. Late night commits have some disadvantages :) Thanks for spotting!
| @@ -390,7 +391,7 @@ private int flushGroup() throws IOException { | |||
|
|
|||
| if (++chainLengths[hash] > 20) { | |||
| throw new RuntimeException( | |||
| "Too many collisions, please report this to dev@lucene.apache.org"); | |||
There was a problem hiding this comment.
I wonder whether this message should remain as it was. Most people will use it out of the box and we can then count on their feedback if something is not right. Those who do override the default will certainly know where to look (we can report the hashFactor as part of the exception message, perhaps)?
There was a problem hiding this comment.
Something like this? Too many collisions. Try a larger Dictionary#hashFactor. If this doesn't help, please report this to dev@lucene.apache.org?
There was a problem hiding this comment.
Yep, something like it. Maybe even provide some diagnostics?:
"Too many collisions. Try a larger Dictionary#hashFactor (now: " + hashFactor() + "). If this doesn't help, please report this to dev@lucene.apache.org"
* hunspell: make the hash table load factor customizable (cherry picked from commit 1af68bf)
No description provided.