Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hunspell: check for aff file wellformedness more strictly #12468

Merged
merged 2 commits into from Jul 29, 2023

Conversation

donnerpeter
Copy link
Contributor

Description

@donnerpeter donnerpeter requested a review from dweiss July 28, 2023 16:42
return new Dictionary(tempDir, "dictionary", affix, dictionary) {
@Override
protected boolean tolerateAffixRuleCountMismatches() {
return true;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some checked dictionaries contain rule count mismatches :(

Copy link
Contributor

@dweiss dweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@donnerpeter donnerpeter merged commit 32ec382 into apache:main Jul 29, 2023
5 checks passed
@donnerpeter donnerpeter deleted the peter/brokenAff branch July 29, 2023 19:47
donnerpeter added a commit that referenced this pull request Sep 12, 2023
* hunspell: check for .aff file well-formedness more strictly

(cherry picked from commit 32ec382)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants