Remove unused variable in BKDWriter #12512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyice
changed the title
|
From what I can tell, it stopped being used after this commit: 5d1d644#diff-12a84802489e3d06f69565f493e8f1b19147e26b1bbb995551a58351ff6f8c92 @iverase does this removal seem cool? I agree, it doesn't look like its used anywhere. |
|
Sure, it is probably a left over from another change. Now that we are here I think we should rename |
|
@iverase It is a good idea, this seems clearer, I've renamed |
|
LGTM, Thanks @easyice ! Could you please add a CHANGES entry under 9.8.0? |
|
Thanks for @iverase and @benwtrent, the CHANGES.txt has updated |
iverase
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The variable
scratch2is never used