Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offload single slice to executor #12515

Merged
merged 4 commits into from
Sep 5, 2023

Conversation

javanna
Copy link
Contributor

@javanna javanna commented Aug 21, 2023

When an executor is set to the IndexSearcher, we should try and offload most of the computation to such executor. Ideally, the caller thread would only do light coordination work, and the executor is responsible for the heavier workload. If we don't offload sequential execution to the executor, it becomes very difficult to make any distinction about the type of workload performed on the two sides.

When an executor is set to the IndexSearcher, we should try and offload
most of the computation to such executor. Ideally, the caller thread
would only do light coordination work, and the executor is responsible
for the heavier workload. If we don't offload sequential execution to
the executor, it becomes very difficult to make any distinction about
the type of workload performed on the two sides.

Closes apache#12498
@javanna javanna requested a review from iverase August 24, 2023 19:00
Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a change that is important to mention in release notes under "Changes in runtime behavior"?

@javanna
Copy link
Contributor Author

javanna commented Sep 5, 2023

I added the entry to the changelog, I now have a test failure around exception handling which is going to be addressed by #12516 , so I'd merge that one first and only then this PR.

@javanna javanna merged commit da89415 into apache:main Sep 5, 2023
4 checks passed
javanna added a commit that referenced this pull request Sep 5, 2023
When an executor is set to the IndexSearcher, we should try and offload
most of the computation to such executor. Ideally, the caller thread
would only do light coordination work, and the executor is responsible
for the heavier workload. If we don't offload sequential execution to
the executor, it becomes very difficult to make any distinction about
the type of workload performed on the two sides.

Closes #12498
jpountz added a commit to jpountz/elasticsearch that referenced this pull request Sep 6, 2023
jpountz added a commit to elastic/elasticsearch that referenced this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants