TaskExecutor waits for all tasks to complete before returning #12523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javanna
requested changes
Sep 5, 2023
lucene/core/src/java/org/apache/lucene/search/TaskExecutor.java
Outdated
Show resolved
Hide resolved
lucene/core/src/test/org/apache/lucene/search/TestIndexSearcher.java
Outdated
Show resolved
Hide resolved
quux00
force-pushed
the
concurrent-search/wait-on-all-tasks
branch
from
a811d0e
to
51d47e5
Compare
waits until all tasks have finished before returning, even when one or more of the tasks throw an Exception.
…ion to the original one
…tion to use a CountDownLatch rather than sleep
quux00
force-pushed
the
concurrent-search/wait-on-all-tasks
branch
from
51d47e5
to
ba5d115
Compare
javanna
reviewed
Oct 2, 2023
lucene/core/src/test/org/apache/lucene/search/TestIndexSearcher.java
Outdated
Show resolved
Hide resolved
lucene/core/src/test/org/apache/lucene/search/TestIndexSearcher.java
Outdated
Show resolved
Hide resolved
lucene/core/src/test/org/apache/lucene/search/TestIndexSearcher.java
Outdated
Show resolved
Hide resolved
lucene/core/src/test/org/apache/lucene/search/TestIndexSearcher.java
Outdated
Show resolved
Hide resolved
lucene/core/src/test/org/apache/lucene/search/TestIndexSearcher.java
Outdated
Show resolved
Hide resolved
…ion to use a deterministic single-threaded executor
javanna
reviewed
Oct 3, 2023
lucene/core/src/test/org/apache/lucene/search/TestIndexSearcher.java
Outdated
Show resolved
Hide resolved
quux00
force-pushed
the
concurrent-search/wait-on-all-tasks
branch
from
d9eb713
to
3ed2489
Compare
|
This looks great thanks @quux00 ! Could you add an entry to the lucene/CHANGES.txt file under Lucene 9.9 please? |
quux00
force-pushed
the
concurrent-search/wait-on-all-tasks
branch
from
f206f52
to
6be6d13
Compare
|
Thanks @quux00 ! |
javanna
pushed a commit
that referenced
this pull request
Oct 5, 2023
The TaskExecutor used to run concurrent operations may leave running tasks behind when an exception is thrown by one of the tasks. This commit ensures that it instead waits for all tasks to complete before it re-throws the exception. If there's more than one exception thrown, they are going to be added as suppressed exceptions to the first one that was caught.
s1monw
pushed a commit
to s1monw/lucene
that referenced
this pull request
Oct 10, 2023
…#12523) The TaskExecutor used to run concurrent operations may leave running tasks behind when an exception is thrown by one of the tasks. This commit ensures that it instead waits for all tasks to complete before it re-throws the exception. If there's more than one exception thrown, they are going to be added as suppressed exceptions to the first one that was caught.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TaskExecutor used by IndexSearcher and AbstractKnnVectorQuery
waits until all tasks have finished before returning, even when
one or more of the tasks throw an Exception.
Relates #12278