Let WordDelimiterGraphFilterFactory propagate ignoreKeywords flag #12525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanvodita
approved these changes
Nov 22, 2023
mikemccand
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Thank you @thomasdc and @stefanvodita -- this trivial change makes sense, exposing a missing option to the factory for WordDelimiterGraphFilter. I wish we had some automated / static way to confirm that the analysis factories all expose the options accepted by the underlying classes, but that can come later.
I'll merge and backport -- this is very low risk for 9.9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WordDelimiterGraphFilteralready contains support for theIGNORE_KEYWORDSflag. This commits enables propagating that flag from theWordDelimiterGraphFilterFactory.Fixes #12522.