Deprecate IndexSearcher#getExecutor #12578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have recently introduced a TaskExecutor abstraction, which is meant to be used to execute concurrent tasks using the executor provided to the IndexSearcher constructor. All concurrenct tasks should be executed using the TaskExecutor, and there shoul be no reason to retrieve the Executor directly from the IndexSearcher.
uschindler
approved these changes
Sep 20, 2023
Yes. but I'll open a PR against main to have people double check the change. You'll get summoned there too ;) |
javanna
added a commit
that referenced
this pull request
Sep 21, 2023
Use getTaskExecutor instead. This is important to enforce tracking of tasks that run in each thread. Relates to #12578
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have recently introduced a TaskExecutor abstraction, which is meant to be used to execute concurrent tasks using the executor provided to the IndexSearcher constructor. All concurrenct tasks should be executed using the TaskExecutor, and there shoul be no reason to retrieve the Executor directly from the IndexSearcher.