Simplify TaskExecutor API #12603
Merged
Simplify TaskExecutor API #12603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently made TaskExecutor public. It currently exposes two methods: one to create tasks given a collection of callables, and one to execute all tasks created at step 1. We can rather expose a single public method that takes a collection of callables which internally creates the appropriate tasks. This simplifies the API, and stops us from leaking the internal Task abstraction which can be kept private. Note that this is backwards compatible as we have not released yet a version where the TaskExecutor was made public. It is marked experimental anyways.
javanna
added a commit
that referenced
this pull request
Oct 2, 2023
We recently made TaskExecutor public. It currently exposes two methods: one to create tasks given a collection of callables, and one to execute all tasks created at step 1. We can rather expose a single public method that takes a collection of callables which internally creates the appropriate tasks. This simplifies the API, and stops us from leaking the internal Task abstraction which can be kept private. Note that this is backwards compatible as we have not released yet a version where the TaskExecutor was made public. It is marked experimental anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently made TaskExecutor public. It currently exposes two methods: one to create tasks given a collection of callables, and one to execute all tasks created at step 1. We can rather expose a single public method that takes a collection of callables which internally creates the appropriate tasks. This simplifies the API, and stops us from leaking the internal Task abstraction which can be kept private.
Note that this is backwards compatible as we have not released yet a version where the TaskExecutor was made public. It is marked experimental anyways.