Refactor access to VM options and move some VM options to oal.util.Constants #12754
Conversation
…so in PanamaVectorUtilSupport); move detection of Client VM and fast FMA support to Constants
| public static final boolean HAS_FAST_FMA = | ||
| (IS_CLIENT_VM == false) | ||
| && Constants.OS_ARCH.equals("amd64") | ||
| && HotspotVMOptions.get("UseFMA").map(Boolean::valueOf).orElse(false); |
There was a problem hiding this comment.
Can we update this with the current logic in the other branch? With the newer Neoverse cores that support SVE, they "fixed" their FMA to be fast, so we turn it on there too. It is a good exercise as well since it must check integer parameter.
There was a problem hiding this comment.
I am fine with both. I just used here the code as is on current main branch.
There was a problem hiding this comment.
ok, that makes sense. sorry i've been working off the other branch as a baseline for a while.
There was a problem hiding this comment.
I will merge it to your branch once merged to main/9.x
uschindler
changed the title
|
Hi @rmuir , |
|
I fixed a regression with OpenJ9 in 5358b72. |
This code was previously in
RamUsageEstimatorand also inPanamaVectorUtilSupport.In addition this moves detection of Client VM and fast FMA support to
Constantsclass (in preparation for #12737).